Switch to libtest-mimic for wit-bindgen-test #1496
Merged
+245
−248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In poking around at bytecodealliance#1495 I found that there was no way to actually print the name of the current test being run. I also found that it wouldn't be easy to print the name of the test as it was run before it started running to figure out which test was hanging. Instead of building out infrastructure to do this I've instead opted to switch to using `libtest-mimic`-the-crate also being used in wasm-tools and Wasmtime. This should help add these options by default and while it's not a standard embedding it's close enough. The main downside with this is that `libtest-mimic` requires `'static` tests which was not implemented in this crate. That required a lot of clones to get lifetimes to line up.
dicej
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In poking around at #1495 I found that there was no way to actually print the name of the current test being run. I also found that it wouldn't be easy to print the name of the test as it was run before it started running to figure out which test was hanging. Instead of building out infrastructure to do this I've instead opted to switch to using
libtest-mimic-the-crate also being used in wasm-tools and Wasmtime. This should help add these options by default and while it's not a standard embedding it's close enough.The main downside with this is that
libtest-mimicrequires'statictests which was not implemented in this crate. That required a lot of clones to get lifetimes to line up.